Reviewers: jgw,

Description:
Description:
============
We currently enable scrolling by setting overflow to an empty string
instead of ''.  In Chrome, setting the overflow to '' does not have any
effect until a window resize.

Actually, we used to set it to auto, but switched at r1949 because of a
FF issue:
http://code.google.com/p/google-web-toolkit/issues/detail?id=1390

It looks like newer versions of firefox (3.0+) aren't affected by this
bug.


Fix:
====
We now set overflow to 'auto'.


Testing:
=========
Verified that WindowTest#testGetClientSize() passes on firefox, ie6,
ie7, safari, and chrome.

Please review this at http://gwt-code-reviews.appspot.com/91804

Affected files:
   user/src/com/google/gwt/dom/client/Document.java


Index: user/src/com/google/gwt/dom/client/Document.java
===================================================================
--- user/src/com/google/gwt/dom/client/Document.java    (revision 6580)
+++ user/src/com/google/gwt/dom/client/Document.java    (working copy)
@@ -1097,7 +1097,7 @@
     */
    public final void enableScrolling(boolean enable) {
      getViewportElement().getStyle().setProperty("overflow",
-        enable ? "" : "hidden");
+        enable ? "auto" : "hidden");
    }

    /**



--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to