Yeah, the formatting is incorrect. The default formatting on my eclipse seems incorrect.
I will upload a re-formatted patch, after fixing the eclipse issue. Thanks John. On Mon, Nov 2, 2009 at 2:09 PM, <[email protected]> wrote: > > http://gwt-code-reviews.appspot.com/91806/diff/1/3 > File user/src/com/google/gwt/junit/JUnitShell.java (right): > > http://gwt-code-reviews.appspot.com/91806/diff/1/3#newcode698 > Line 698: getTopLogger().log(TreeLogger.ERROR, > This formatting change doesn't look right (the previous version fit fine > in 80 characters) and is unrelated to the actual change being made. > > http://gwt-code-reviews.appspot.com/91806/diff/1/4 > File user/src/com/google/gwt/junit/RunStyle.java (right): > > http://gwt-code-reviews.appspot.com/91806/diff/1/4#newcode78 > Line 78: * an error setting up for that mode > These changes aren't related and I think are actually incorrect, since > continuation lines should be indented 4 characters. > > > http://gwt-code-reviews.appspot.com/91806 > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
