LGTM, but with a few small changes requested. No need for rereview.
http://gwt-code-reviews.appspot.com/89810/diff/1/2 File dev/core/src/com/google/gwt/dev/jjs/impl/FragmentExtractor.java (right): http://gwt-code-reviews.appspot.com/89810/diff/1/2#newcode175 Line 175: * the call to vtableInitToMethod()? It sounds like using vtableInitToMethod is enough. So, this code can be deleted. However, please do check that, say, the initial download of Showcase is not changing. http://gwt-code-reviews.appspot.com/89810/diff/1/4 File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java (right): http://gwt-code-reviews.appspot.com/89810/diff/1/4#newcode1725 Line 1725: * turning named polymorphic functions into anonymous functions. This TODO appears twice. http://gwt-code-reviews.appspot.com/89810/diff/1/3 File dev/core/src/com/google/gwt/dev/js/EvalFunctionsAtTopScope.java (right): http://gwt-code-reviews.appspot.com/89810/diff/1/3#newcode116 Line 116: if (x.getName() != null && !dontMove.contains(x) && func == x) { I believe this code would be simpler if you made it a visit on JsExprStmt rather than a visit on JsFunction. Then you don't need the currentStatement field. http://gwt-code-reviews.appspot.com/89810 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
