LGTM

http://gwt-code-reviews.appspot.com/89810/diff/4001/4006
File dev/core/src/com/google/gwt/dev/js/EvalFunctionsAtTopScope.java
(right):

http://gwt-code-reviews.appspot.com/89810/diff/4001/4006#newcode74
Line 74:
Extra whitespace in this file.

http://gwt-code-reviews.appspot.com/89810/diff/4001/4002
File dev/core/src/com/google/gwt/dev/js/JsStackEmulator.java (right):

http://gwt-code-reviews.appspot.com/89810/diff/4001/4002#newcode784
Line 784: * Corresponds to property compiler.stackMode in EmulateJsStack
module.
Add a note to this comment about which gwt.xml file needs to be kept in
sync.

http://gwt-code-reviews.appspot.com/89810/diff/4001/4003
File user/src/com/google/gwt/core/client/impl/StackTraceCreator.java
(right):

http://gwt-code-reviews.appspot.com/89810/diff/4001/4003#newcode344
Line 344: * When compiler.stackMode = strip, we stub out the collector.
Good choice.

http://gwt-code-reviews.appspot.com/89810

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to