Fantastic. Just a couple of doc issues.

http://gwt-code-reviews.appspot.com/89818/diff/1/3
File samples/mail/src/com/google/gwt/sample/mail/client/MailList.java
(right):

http://gwt-code-reviews.appspot.com/89818/diff/1/3#newcode81
Line 81: dock.forceLayout();
Should add comment explaining why

http://gwt-code-reviews.appspot.com/89818/diff/1/10
File user/src/com/google/gwt/layout/client/Layout.java (right):

http://gwt-code-reviews.appspot.com/89818/diff/1/10#newcode449
Line 449: * called after updating any of its children's {...@link Layer
layers}.
"must be called..." Still true?

http://gwt-code-reviews.appspot.com/89818/diff/1/14
File user/src/com/google/gwt/user/client/ui/DockLayoutPanel.java
(right):

http://gwt-code-reviews.appspot.com/89818/diff/1/14#newcode32
Line 32: * to update the panel's layout.
No longer true, right?

http://gwt-code-reviews.appspot.com/89818/diff/1/14#newcode177
Line 177: * Gets the container element wrapping the given child widget.
Any guidance on when you might call this? What not to do with it?

http://gwt-code-reviews.appspot.com/89818

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to