Many thanks. Committed with review tweaks @r6624.
http://gwt-code-reviews.appspot.com/89818/diff/1/3 File samples/mail/src/com/google/gwt/sample/mail/client/MailList.java (right): http://gwt-code-reviews.appspot.com/89818/diff/1/3#newcode81 Line 81: dock.forceLayout(); On 2009/11/03 21:57:19, Ray Ryan wrote: > Should add comment explaining why Actually, that shouldn't have been there at all. http://gwt-code-reviews.appspot.com/89818/diff/1/10 File user/src/com/google/gwt/layout/client/Layout.java (right): http://gwt-code-reviews.appspot.com/89818/diff/1/10#newcode449 Line 449: * called after updating any of its children's {...@link Layer layers}. On 2009/11/03 21:57:19, Ray Ryan wrote: > "must be called..." Still true? Yup. The underlying layout system still uses a "set lots of properties then pull the crank" API. The widgets built on top of it just take care of doing so automagically. http://gwt-code-reviews.appspot.com/89818/diff/1/14 File user/src/com/google/gwt/user/client/ui/DockLayoutPanel.java (right): http://gwt-code-reviews.appspot.com/89818/diff/1/14#newcode32 Line 32: * to update the panel's layout. On 2009/11/03 21:57:19, Ray Ryan wrote: > No longer true, right? Whoops, good catch. Thanks. http://gwt-code-reviews.appspot.com/89818 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
