What is an SSW? Dan
On Wed, Nov 4, 2009 at 2:24 PM, <[email protected]> wrote: > LGTM, just nits. > > > http://gwt-code-reviews.appspot.com/90802/diff/1004/2001 > File user/super/com/google/gwt/emul/java/util/Date.java (right): > > http://gwt-code-reviews.appspot.com/90802/diff/1004/2001#newcode110 > Line 110: * A private copy of the hour within the day. > @see #fixDaylightSavings > > http://gwt-code-reviews.appspot.com/90802/diff/1004/2001#newcode311 > Line 311: > Whitespace. > > http://gwt-code-reviews.appspot.com/90802/diff/1004/2001#newcode337 > Line 337: // hours and minutes of the requested time. > Move this to a block comment outside of the method so that it will > auto-format more readily > > http://gwt-code-reviews.appspot.com/90802/diff/1004/2002 > File user/test/com/google/gwt/emultest/java/util/DateTest.java (right): > > http://gwt-code-reviews.appspot.com/90802/diff/1004/2002#newcode642 > Line 642: private boolean findClockForwardTime(int year, int[] > monthDayHour) { > If the user is in a timezone that doesn't observe DST, will this method > complete in web mode without throwing a SSW? > > http://gwt-code-reviews.appspot.com/90802/diff/3003/3005#newcode642 > Line 642: private boolean findClockForwardTime(int year, int[] > monthDayHour) { > Sort order. > > > http://gwt-code-reviews.appspot.com/90802 > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
