http://gwt-code-reviews.appspot.com/96804/diff/1/2 File user/src/com/google/gwt/uibinder/rebind/GwtResourceEntityResolver.java (right):
http://gwt-code-reviews.appspot.com/96804/diff/1/2#newcode49 Line 49: "https://dl-ssl.google.com/download/gwt/DTD/"})); Re: version, only if we want to get into the business of baking every version number into the binary, and providing a redirect mechanism of our own. I don't, especially as I never expect this file to change. If I'm wrong, we can retrofit. Re: http, sure, I'd prefer it. Does lorry support both? http://gwt-code-reviews.appspot.com/96804/diff/1/4 File user/src/com/google/gwt/uibinder/rebind/W3cDomHelper.java (right): http://gwt-code-reviews.appspot.com/96804/diff/1/4#newcode44 Line 44: public W3cDomHelper(final TreeLogger logger) { On 2009/11/06 02:12:53, jat wrote: > Javadoc, mentioning that logger can be null since it is called that way? No it can't. Where do you see it called that way? > Speaking of which, it looks like you would get NPE below. Either this should > handle a null logger, or the callers should supply a dummy logger. That's what TreeLogger.NULL is for. http://gwt-code-reviews.appspot.com/96804/diff/1/4#newcode54 Line 54: builder.setErrorHandler(new ErrorHandler() { Oops, this does not belong in this patch. And that explains your confusion about the NPE, I think. http://gwt-code-reviews.appspot.com/96804/diff/1/9 File user/test/com/google/gwt/uibinder/test/client/WidgetBasedUi.ui.xml (right): http://gwt-code-reviews.appspot.com/96804/diff/1/9#newcode31 Line 31: allows you to use familiar HTML entities like %nbsp; and •, Thanks, will fix. http://gwt-code-reviews.appspot.com/96804 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
