Hard to keep up with all your patches, so some of these may overlap or make no sense for later changes :)
http://gwt-code-reviews.appspot.com/96804/diff/1/2 File user/src/com/google/gwt/uibinder/rebind/GwtResourceEntityResolver.java (right): http://gwt-code-reviews.appspot.com/96804/diff/1/2#newcode49 Line 49: "https://dl-ssl.google.com/download/gwt/DTD/"})); On 2009/11/06 02:18:47, Ray Ryan wrote: > Re: version, only if we want to get into the business of baking every version > number into the binary, and providing a redirect mechanism of our own. I don't, > especially as I never expect this file to change. If I'm wrong, we can retrofit. Ok. > Re: http, sure, I'd prefer it. Does lorry support both? Yes, you can optionally serve on http as well as https. I suggest making it available for both and including both here. http://gwt-code-reviews.appspot.com/96804/diff/1/4 File user/src/com/google/gwt/uibinder/rebind/W3cDomHelper.java (right): http://gwt-code-reviews.appspot.com/96804/diff/1/4#newcode44 Line 44: public W3cDomHelper(final TreeLogger logger) { On 2009/11/06 02:18:47, Ray Ryan wrote: > On 2009/11/06 02:12:53, jat wrote: > > Javadoc, mentioning that logger can be null since it is called that way? > No it can't. Where do you see it called that way? > > > > Speaking of which, it looks like you would get NPE below. Either this should > > handle a null logger, or the callers should supply a dummy logger. > That's what TreeLogger.NULL is for. My bad, wasn't thinking right -- TreeLogger.NULL is exactly that dummy logger. http://gwt-code-reviews.appspot.com/96804/diff/1/5 File user/src/com/google/gwt/uibinder/resources/xhtml.ent (right): http://gwt-code-reviews.appspot.com/96804/diff/1/5#newcode20 Line 20: SYSTEM "https://dl-ssl.google.com/download/gwt/DTD/xhtml.ent";> Also mention http here. http://gwt-code-reviews.appspot.com/96804/diff/1005/1006 File user/src/com/google/gwt/uibinder/rebind/GwtResourceEntityResolver.java (right): http://gwt-code-reviews.appspot.com/96804/diff/1005/1006#newcode38 Line 38: * <code>http://google-web-toolkit.googlecode.com/files</code>, provide the Update this example. http://gwt-code-reviews.appspot.com/96804/diff/1005/1007 File user/src/com/google/gwt/uibinder/resources/xhtml.ent (right): http://gwt-code-reviews.appspot.com/96804/diff/1005/1007#newcode20 Line 20: SYSTEM "https://dl-ssl.google.com/download/gwt/DTD/xhtml.ent";> Mention http as well here. http://gwt-code-reviews.appspot.com/96804/diff/1005/1009 File user/test/com/google/gwt/uibinder/test/client/WidgetBasedUi.ui.xml (right): http://gwt-code-reviews.appspot.com/96804/diff/1005/1009#newcode29 Line 29: SYSTEM "https://dl-ssl.google.com/download/gwt/DTD/xhtml.ent"; Mention both https and http here. http://gwt-code-reviews.appspot.com/96804/diff/20/1010 File user/src/com/google/gwt/uibinder/rebind/GwtResourceEntityResolver.java (right): http://gwt-code-reviews.appspot.com/96804/diff/20/1010#newcode38 Line 38: * <code>http://google-web-toolkit.googlecode.com/files</code>, provide the Update the example. http://gwt-code-reviews.appspot.com/96804/diff/20/1010#newcode49 Line 49: "http://dl.google.com/download/gwt/DTD/"})); I think you should keep https as well. http://gwt-code-reviews.appspot.com/96804 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
