LGTM - Just double check what state the system is in if you throw the
IllegalStateExceptions.


http://gwt-code-reviews.appspot.com/98801/diff/1/3
File dev/core/src/com/google/gwt/dev/shell/remoteui/RemoteUI.java
(right):

http://gwt-code-reviews.appspot.com/98801/diff/1/3#newcode119
Line 119: throw new IllegalStateException(
Sure, that you want to throw IllegalStateException?  What happens?

http://gwt-code-reviews.appspot.com/98801/diff/1/3#newcode125
Line 125: throw new IllegalStateException(
Same comment as line 119.

http://gwt-code-reviews.appspot.com/98801

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to