Thanks for the review!
http://gwt-code-reviews.appspot.com/98801/diff/1/3 File dev/core/src/com/google/gwt/dev/shell/remoteui/RemoteUI.java (right): http://gwt-code-reviews.appspot.com/98801/diff/1/3#newcode119 Line 119: throw new IllegalStateException( On 2009/11/09 17:07:10, mmendez wrote: > Sure, that you want to throw IllegalStateException? What happens? You're right - this is not the best place to throw this exception. Though the only caller is DevModeServiceRequestProcessor.processRestartServer, someone else would call this method and get unexpected results. Changed this method to return a boolean. DevModServiceRequestProcess.processRestartServer now throws an IllegalStateException, which ends up getting sent back over the wire as a failure message. http://gwt-code-reviews.appspot.com/98801/diff/1/3#newcode125 Line 125: throw new IllegalStateException( On 2009/11/09 17:07:10, mmendez wrote: > Same comment as line 119. Done. http://gwt-code-reviews.appspot.com/98801 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
