http://gwt-code-reviews.appspot.com/100803/diff/1/2 File user/src/com/google/gwt/uibinder/resources/UiBinder.xsd (right):
http://gwt-code-reviews.appspot.com/100803/diff/1/2#newcode126 Line 126: Be safe by allowing any content (text or elements). This pattern is Actually, the generator makes it an error to have non-text inside UiStyle. Text is tolerated for the other ui:* elements, and WidgetBaseUi.ui.xml uses that to document some of them, but I wonder if that was a mistake. http://gwt-code-reviews.appspot.com/100803/diff/1/2#newcode246 Line 246: use="required" /> This needs optional key, description and meaning too. It's just like ui:msg, plus a name--maybe you can factor out a type for them to share? http://gwt-code-reviews.appspot.com/100803/diff/1/2#newcode304 Line 304: </xs:element> I don't see ui:field or ui:ph (attribute) in here? http://gwt-code-reviews.appspot.com/100803/diff/1/3 File user/src/com/google/gwt/uibinder/resources/com.google.gwt.user.client.ui.xsd (right): http://gwt-code-reviews.appspot.com/100803/diff/1/3#newcode75 Line 75: maxOccurs="unbounded"> Thought you were going to make these max 1? http://gwt-code-reviews.appspot.com/100803/diff/1/3#newcode238 Line 238: </xs:attribute> missing required attribute size http://gwt-code-reviews.appspot.com/100803/diff/1/3#newcode384 Line 384: name="customHeader"> What about the non-custom header? Like DisclosurePanel and <g:tab>, this can have either <g:header>html</g:header> or <g:customHeader><widget></g:customHeader> http://gwt-code-reviews.appspot.com/100803/diff/1/3#newcode457 Line 457: type="xs:string" /> required http://gwt-code-reviews.appspot.com/100803/diff/1/3#newcode469 Line 469: name="MixedContentType" Could you put a comment explaining what this is? http://gwt-code-reviews.appspot.com/100803/diff/1/3#newcode484 Line 484: name="ElementContentType"> Could you put a comment explaining what this is? http://gwt-code-reviews.appspot.com/100803 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
