Nearly there. (For future reference, Rietveld's logs are a lot more
useful if you reply through its UI.)


http://gwt-code-reviews.appspot.com/100803/diff/7/8
File user/src/com/google/gwt/uibinder/resources/UiBinder.xsd (right):

http://gwt-code-reviews.appspot.com/100803/diff/7/8#newcode302
Line 302: <xs:attribute
Thanks for adding these, but now I wonder if you really want to bother.
I'm not a big believer in unexercised code, and I think this counts as
such.

http://gwt-code-reviews.appspot.com/100803/diff/7/9
File
user/src/com/google/gwt/uibinder/resources/com.google.gwt.user.client.ui.xsd
(right):

http://gwt-code-reviews.appspot.com/100803/diff/7/9#newcode241
Line 241: name="size"
Sorry, wrong place. The actual deal is that each of north, south east
and west require size. And center doesn't.

http://gwt-code-reviews.appspot.com/100803/diff/7/9#newcode404
Line 404: type="xs:string" />
Required, and also required of plain old header

http://gwt-code-reviews.appspot.com/100803

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to