Minor suggestions.

http://gwt-code-reviews.appspot.com/102819/diff/1/6
File dev/core/src/com/google/gwt/core/ext/DefaultSelectionProperty.java
(right):

http://gwt-code-reviews.appspot.com/102819/diff/1/6#newcode101
Line 101: + possibleValues.toString();
No use of fallbackValue?

http://gwt-code-reviews.appspot.com/102819/diff/1/2
File dev/core/src/com/google/gwt/dev/cfg/StaticPropertyOracle.java
(right):

http://gwt-code-reviews.appspot.com/102819/diff/1/2#newcode155
Line 155: return new DefaultSelectionProperty(value, fallback, name,
inline fallback?

http://gwt-code-reviews.appspot.com/102819/diff/1/11
File user/src/com/google/gwt/i18n/rebind/LocaleUtils.java (right):

http://gwt-code-reviews.appspot.com/102819/diff/1/11#newcode55
Line 55: super();
why the super() call?

http://gwt-code-reviews.appspot.com/102819/diff/1/7
File user/src/com/google/gwt/i18n/server/GwtLocaleFactoryImpl.java
(right):

http://gwt-code-reviews.appspot.com/102819/diff/1/7#newcode80
Line 80:
use ConcurrentHashMap? Can avoid the lock.

http://gwt-code-reviews.appspot.com/102819

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to