Thanks for the review.
http://gwt-code-reviews.appspot.com/102819/diff/1/6 File dev/core/src/com/google/gwt/core/ext/DefaultSelectionProperty.java (right): http://gwt-code-reviews.appspot.com/102819/diff/1/6#newcode101 Line 101: + possibleValues.toString(); On 2009/11/16 19:51:53, amitmanjhi wrote: > No use of fallbackValue? This is just for debugging to make it easier to see what is going on. If you think it is important here, it is easy enough to add. http://gwt-code-reviews.appspot.com/102819/diff/1/2 File dev/core/src/com/google/gwt/dev/cfg/StaticPropertyOracle.java (right): http://gwt-code-reviews.appspot.com/102819/diff/1/2#newcode155 Line 155: return new DefaultSelectionProperty(value, fallback, name, On 2009/11/16 19:51:53, amitmanjhi wrote: > inline fallback? Done. http://gwt-code-reviews.appspot.com/102819/diff/1/11 File user/src/com/google/gwt/i18n/rebind/LocaleUtils.java (right): http://gwt-code-reviews.appspot.com/102819/diff/1/11#newcode55 Line 55: super(); On 2009/11/16 19:51:53, amitmanjhi wrote: > why the super() call? Leftover from Eclipse auto-gen code. Removed. http://gwt-code-reviews.appspot.com/102819/diff/1/7 File user/src/com/google/gwt/i18n/server/GwtLocaleFactoryImpl.java (right): http://gwt-code-reviews.appspot.com/102819/diff/1/7#newcode80 Line 80: On 2009/11/16 19:51:53, amitmanjhi wrote: > use ConcurrentHashMap? Can avoid the lock. I don't believe so, as you have to hold the lock across containsKey/get/put. http://gwt-code-reviews.appspot.com/102819 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
