LGTM
http://gwt-code-reviews.appspot.com/112812/diff/1/4 File user/src/com/google/gwt/uibinder/elementparsers/DisclosurePanelParser.java (right): http://gwt-code-reviews.appspot.com/112812/diff/1/4#newcode72 Line 72: && !(openImage == closedImage)) { I know what you mean here, but string comparison with == always looks wrong. What you want is xnor. if (!(openImage == null ^ closedImage == null)) http://gwt-code-reviews.appspot.com/112812/diff/1/4#newcode75 Line 75: } is openImage="" a legal value? http://gwt-code-reviews.appspot.com/112812/diff/1/11 File user/test/com/google/gwt/uibinder/rebind/XMLElementTest.java (left): http://gwt-code-reviews.appspot.com/112812/diff/1/11#oldcode202 Line 202: public void testConsumeDouble() throws UnableToCompleteException, Did you mean to delete this test? http://gwt-code-reviews.appspot.com/112812/diff/1/11 File user/test/com/google/gwt/uibinder/rebind/XMLElementTest.java (right): http://gwt-code-reviews.appspot.com/112812/diff/1/11#newcode159 Line 159: assertNotNull(logger.died); Is there code somewhere that resets logger.died? http://gwt-code-reviews.appspot.com/112812 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
