Thanks for the review. Responses and updates are here, submitting soon.
http://gwt-code-reviews.appspot.com/112812/diff/1/4 File user/src/com/google/gwt/uibinder/elementparsers/DisclosurePanelParser.java (right): http://gwt-code-reviews.appspot.com/112812/diff/1/4#newcode72 Line 72: && !(openImage == closedImage)) { Nice! Thanks, forgot about xor. But the ! is wrong. http://gwt-code-reviews.appspot.com/112812/diff/1/4#newcode75 Line 75: } No. Empty strings we can work with. Empty other things are parse errors. StrictAttributeParser enforces that (now) http://gwt-code-reviews.appspot.com/112812/diff/1/11 File user/test/com/google/gwt/uibinder/rebind/XMLElementTest.java (left): http://gwt-code-reviews.appspot.com/112812/diff/1/11#oldcode202 Line 202: public void testConsumeDouble() throws UnableToCompleteException, Yes. consumeDoubleAttribute was unused, so I nuked it. (Everyone uses consumeRequiredDoubleAttribute). If it's needed again its easy to restore. Don't like vestigial code. http://gwt-code-reviews.appspot.com/112812/diff/1/11 File user/test/com/google/gwt/uibinder/rebind/XMLElementTest.java (right): http://gwt-code-reviews.appspot.com/112812/diff/1/11#newcode159 Line 159: assertNotNull(logger.died); Oops, thanks. Fixed. http://gwt-code-reviews.appspot.com/112812 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
