A few more comments.
http://gwt-code-reviews.appspot.com/134810/diff/4001/4003 File dev/core/src/com/google/gwt/dev/jjs/ast/JAnnotation.java (right): http://gwt-code-reviews.appspot.com/134810/diff/4001/4003#newcode40 Line 40: public static class Property<T extends JNode & JAnnotationArgument> extends Is there a really compelling reason to templatize this? Why not just write this class in terms of JAnnotationArgument? http://gwt-code-reviews.appspot.com/134810/diff/4001/4003#newcode72 Line 72: public List<T> getValues() { BTW: dumb question I should have asked before.. how can an annotation field have more than one value? Isn't this really just a single value, which in some cases is a JNewArray? http://gwt-code-reviews.appspot.com/134810/diff/4001/4014 File dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java (right): http://gwt-code-reviews.appspot.com/134810/diff/4001/4014#newcode91 Line 91: Arrays.asList("com.google.gwt.dev.jjs", "test")); Having test in here seems wonky. Given that this set is not immutable, can't the test code just add this? http://gwt-code-reviews.appspot.com/134810 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
