http://gwt-code-reviews.appspot.com/134810/diff/4001/4003
File dev/core/src/com/google/gwt/dev/jjs/ast/JAnnotation.java (right):

http://gwt-code-reviews.appspot.com/134810/diff/4001/4003#newcode40
Line 40: public static class Property<T extends JNode &
JAnnotationArgument> extends
I guess I kind of see that, but it seems like a lot of unnecessarily
complication for almost no benefit.  Just looking through the patch, it
seems like I was looking at a whole lot more of "<?>" that I could see
instances where we made a cast implicit rather than explicit.

http://gwt-code-reviews.appspot.com/134810/diff/4001/4003#newcode72
Line 72: public List<T> getValues() {
It's more consistent with the rest of the AST, and has the useful
feature that the property value JAnnotationArgument's JType is
definitely compatible with the declared property JType.

http://gwt-code-reviews.appspot.com/134810

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to