Thanks, John. Dan, what do you think about the blacklist parts? Also, would "RegexFilter" be a reasonable name for the pluggable version?
http://gwt-code-reviews.appspot.com/254801/diff/1/2 File user/src/com/google/gwt/precompress/Precompress.gwt.xml (right): http://gwt-code-reviews.appspot.com/254801/diff/1/2#newcode24 user/src/com/google/gwt/precompress/Precompress.gwt.xml:24: <define-linker name="precompress" class="com.google.gwt.precompress.linker.PrecompressLinker" /> I'll do that. I'll put the add-linker in here and ask people to inherit the module if they want it on. http://gwt-code-reviews.appspot.com/254801/diff/1/3 File user/src/com/google/gwt/precompress/linker/PrecompressLinker.java (right): http://gwt-code-reviews.appspot.com/254801/diff/1/3#newcode64 user/src/com/google/gwt/precompress/linker/PrecompressLinker.java:64: SortedSet<com.google.gwt.core.ext.linker.ConfigurationProperty> properties, I'll do that. http://gwt-code-reviews.appspot.com/254801/diff/1/3#newcode110 user/src/com/google/gwt/precompress/linker/PrecompressLinker.java:110: context.getConfigurationProperties(), PROP_PATH_REGEXES).getValues()); From FTF discussions, I'll change it to "filter". http://gwt-code-reviews.appspot.com/254801/diff/1/3#newcode145 user/src/com/google/gwt/precompress/linker/PrecompressLinker.java:145: byte[] buf = new byte[10000]; Okay, I'll make it a constant. http://gwt-code-reviews.appspot.com/254801/diff/1/8 File user/test/com/google/gwt/precompress/linker/PrecompressLinkerTest.java (right): http://gwt-code-reviews.appspot.com/254801/diff/1/8#newcode253 user/test/com/google/gwt/precompress/linker/PrecompressLinkerTest.java:253: artifacts.add(emit("data.xml", fooFileContents())); Good idea. http://gwt-code-reviews.appspot.com/254801/diff/1/8#newcode264 user/test/com/google/gwt/precompress/linker/PrecompressLinkerTest.java:264: propPathRegexes.values.add(".*\\.css"); We talked about this in person. Instead of supplying an empty list, the linker simply won't be used. So this use case should be safe. http://gwt-code-reviews.appspot.com/254801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors To unsubscribe from this group, send email to google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
