LGTM with nits
http://gwt-code-reviews.appspot.com/254801/diff/10001/11004 File user/src/com/google/gwt/util/regexfilter/RegexFilter.java (right): http://gwt-code-reviews.appspot.com/254801/diff/10001/11004#newcode31 user/src/com/google/gwt/util/regexfilter/RegexFilter.java:31: * it indicates that queries matching the regex should be included or excluded Add '.' at end of sentence Document policies determined by implementing acceptByDefault and entriesArePositiveByDefault. http://gwt-code-reviews.appspot.com/254801/diff/10001/11004#newcode39 user/src/com/google/gwt/util/regexfilter/RegexFilter.java:39: * If no pattern matches, then whether the query should be considered as an Remove 'then' http://gwt-code-reviews.appspot.com/254801/diff/10001/11004#newcode64 user/src/com/google/gwt/util/regexfilter/RegexFilter.java:64: logger.log(TreeLogger.ERROR, "Got empty blacklist entry"); 'blacklist' -> 'filter' http://gwt-code-reviews.appspot.com/254801/diff/10001/11004#newcode77 user/src/com/google/gwt/util/regexfilter/RegexFilter.java:77: logger.log(TreeLogger.DEBUG, "Got blacklist entry '" + regex + "'"); ditto http://gwt-code-reviews.appspot.com/254801/diff/10001/11004#newcode79 user/src/com/google/gwt/util/regexfilter/RegexFilter.java:79: logger.log(TreeLogger.ERROR, "Got malformed blacklist entry '" + regex ditto http://gwt-code-reviews.appspot.com/254801/diff/10001/11004#newcode92 user/src/com/google/gwt/util/regexfilter/RegexFilter.java:92: logger.log(TreeLogger.DEBUG, "Considering blacklist rule " ditto http://gwt-code-reviews.appspot.com/254801/diff/10001/11006 File user/test/com/google/gwt/precompress/linker/PrecompressLinkerTest.java (right): http://gwt-code-reviews.appspot.com/254801/diff/10001/11006#newcode256 user/test/com/google/gwt/precompress/linker/PrecompressLinkerTest.java:256: "uncompressible.js is not compressible and should have bene left alone", been http://gwt-code-reviews.appspot.com/254801/diff/10001/11008 File user/test/com/google/gwt/user/rebind/rpc/BlacklistTypeFilterTest.java (right): http://gwt-code-reviews.appspot.com/254801/diff/10001/11008#newcode82 user/test/com/google/gwt/user/rebind/rpc/BlacklistTypeFilterTest.java:82: private MockConfigurationProperty propRpcBlacklist = new MockConfigurationProperty( line wrap? http://gwt-code-reviews.appspot.com/254801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors To unsubscribe from this group, send email to google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
