Mostly LGTM.
http://gwt-code-reviews.appspot.com/289801/diff/1/6 File dev/core/src/com/google/gwt/dev/DevModeBase.java (left): http://gwt-code-reviews.appspot.com/289801/diff/1/6#oldcode444 dev/core/src/com/google/gwt/dev/DevModeBase.java:444: File getShellBaseWorkDir(ModuleDef moduleDef); This option is what Freeland is using to fix some internal build issues -- I am assuming that problem will go away completely with this change, right? http://gwt-code-reviews.appspot.com/289801/diff/1/8 File dev/core/src/com/google/gwt/dev/GWTShell.java (right): http://gwt-code-reviews.appspot.com/289801/diff/1/8#newcode108 dev/core/src/com/google/gwt/dev/GWTShell.java:108: return new File(new File(new File(getWorkDir(), moduleDef.getName()), Is this really the way to form a nested directory reference? Perhaps better to just use PATH_SEPARATOR_CHAR? http://gwt-code-reviews.appspot.com/289801/diff/1/10 File dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java (right): http://gwt-code-reviews.appspot.com/289801/diff/1/10#newcode295 dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java:295: if (os instanceof PendingResource) { So how would this get called with something that isn't a PendingResource? http://gwt-code-reviews.appspot.com/289801/diff/1/12 File dev/core/src/com/google/gwt/dev/util/Util.java (right): http://gwt-code-reviews.appspot.com/289801/diff/1/12#newcode749 dev/core/src/com/google/gwt/dev/util/Util.java:749: "The JVM does not support the compiler's default encoding.", e); Is it safe to rely on the compiler's default encoding rather than explicitly specifying UTF8? http://gwt-code-reviews.appspot.com/289801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors To unsubscribe from this group, send email to google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
