http://gwt-code-reviews.appspot.com/289801/diff/1/6
File dev/core/src/com/google/gwt/dev/DevModeBase.java (left):

http://gwt-code-reviews.appspot.com/289801/diff/1/6#oldcode444
dev/core/src/com/google/gwt/dev/DevModeBase.java:444: File
getShellBaseWorkDir(ModuleDef moduleDef);
Not sure.. this still essentially exists for GWTShell/JUnit, but it
totally disappears for DevMode.

http://gwt-code-reviews.appspot.com/289801/diff/1/8
File dev/core/src/com/google/gwt/dev/GWTShell.java (right):

http://gwt-code-reviews.appspot.com/289801/diff/1/8#newcode108
dev/core/src/com/google/gwt/dev/GWTShell.java:108: return new File(new
File(new File(getWorkDir(), moduleDef.getName()),
I think this is the result of auto-inlining.  I'll break this up a
little.  Actually, we may not even need two levels now, I can probably
get away with just merging it up.

http://gwt-code-reviews.appspot.com/289801/diff/1/10
File dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java
(right):

http://gwt-code-reviews.appspot.com/289801/diff/1/10#newcode295
dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java:295:
if (os instanceof PendingResource) {
This is a Generator-facing API, so a Generator writer could try to
commit some unknown OutputStream.

http://gwt-code-reviews.appspot.com/289801/diff/1/12
File dev/core/src/com/google/gwt/dev/util/Util.java (right):

http://gwt-code-reviews.appspot.com/289801/diff/1/12#newcode749
dev/core/src/com/google/gwt/dev/util/Util.java:749: "The JVM does not
support the compiler's default encoding.", e);
Actually, I totally got this wrong; deleting the whole
UnsupportedEncodingException catch block which was a copy/pasto from
readStringAsObject.

http://gwt-code-reviews.appspot.com/289801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

To unsubscribe from this group, send email to 
google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this email with 
the words "REMOVE ME" as the subject.

Reply via email to