Desk review notes: Add version (Comparable) to valueskey, get it over the wire. Surely we'll need it. No change events from ValueStoreJsonImpl#setValues. They should be a CRUD side effect only. Or maybe not on new during a get, only on change during a get? Try to make EntityListPresenter not tied to ExpensesEntityKey. If that works, move it out of the expenses Get rid of ExpenseRequestFactoryImpl.EmployeeRequest.*(ValueStore), unused Make property an interface, give its implementation a setKey method to avoid crazy private class stuff. Change events should take sets of objects, not one per Give record key string id instead of object ValueStoreJsonImpl: only swizzle incoming recrod ValuesImpl getId to string ValuesImpl#isEmpty is always false b/c of id
http://gwt-code-reviews.appspot.com/290801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors To unsubscribe from this group, send email to google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
