Patch updated: On Tue, Mar 30, 2010 at 10:33 AM, <[email protected]> wrote:
Desk review notes: Add version (Comparable) to valueskey, get it over the wire. Surely we'll need it.
Done
No change events from ValueStoreJsonImpl#setValues. They should be a CRUD side effect only. Or maybe not on new during a get, only on
change
during a get?
Already works that way.
Try to make EntityListPresenter not tied to ExpensesEntityKey. If that works, move it out of the expenses
Nope, it's Expenses specific.
Get rid of ExpenseRequestFactoryImpl.EmployeeRequest.*(ValueStore), unused
Done
Make property an interface, give its implementation a setKey method to avoid crazy private class stuff.
Done, and got rid of RelationshipProperty which was unused so far.
Change events should take sets of objects, not one per
This was less straightforward than expected, and is not a clear win: 95% of the tim only one record will have changed. Added a TODO to reconsider
Give record key string id instead of object
Done
ValueStoreJsonImpl: only swizzle incoming record
We realized this was the wrong thing to do
ValuesImpl getId to string
Done
ValuesImpl#isEmpty is always false b/c of id
Fixed http://gwt-code-reviews.appspot.com/290801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
