On Fri, Apr 9, 2010 at 3:29 PM, <[email protected]> wrote: > On 2010/04/09 15:16:19, jat wrote: > >> Do we need to also change String.valueOf(*) which just uses "" + val? >> > > Good point. There might be other places where JsNumberLiteral is changed > to a String, so we should look at that. Lex, look at > JsToStringGenerationVisitor.visit(JsNumberLiteral x, > JsContext<JsExpression> ctx) for example.
Hmm, that one should be okay, shouldn't it? Anything will do so long as it evaluates correctly. John, I've been thinking about String.valueOf(). That one's tough, because ideally we want the Java conversion. That's generally our story with compiled GWT code: it behaves the same as it would on a JVM. Unfortunately, I don't see an easy way to get the Java meaning when translating to JS. It looks easier to say that GWT uses the JS meaning. In that case, though, we should try to make dev mode also use the JS meaning. -Lex -- http://groups.google.com/group/Google-Web-Toolkit-Contributors To unsubscribe, reply using "remove me" as the subject.
