Interesting subthreads aside, does the change in this patch LGT everyone? On Fri, Apr 9, 2010 at 6:58 PM, John Tamplin <[email protected]> wrote:
> On Fri, Apr 9, 2010 at 6:29 PM, Lex Spoon <[email protected]> wrote: > >> Changing it is fine. However, the ideal change would be to whichever way >> takes the fewest bytes! >> > > Well, not if we are using it in contexts where it is expected to be all > digits, as in the original bug. > > True. In this particular subthread, the context is JsToStringVisitor. This class already discards whitespace and drops comments. It also does rewrites such as 1.23456E5 to 123456, and those are more than fine. Emit it whichever way is shortest. -Lex -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
