Hey John, I took an initial look but I'd like you to look through this
also.


http://gwt-code-reviews.appspot.com/331802/diff/1/2
File dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java
(right):

http://gwt-code-reviews.appspot.com/331802/diff/1/2#newcode374
dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java:374:
throws ClassNotFoundException {
Extra whitespace added? (and on 381).

http://gwt-code-reviews.appspot.com/331802/diff/1/2#newcode994
dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java:994:
private boolean isScriptOnly(String className, byte[] classBytes) {
This needs to be sorted down below injectJsniMethods().

http://gwt-code-reviews.appspot.com/331802/diff/1/2#newcode1037
dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java:1037: */
Even with the comment, I still don't really understand what this is
doing?

http://gwt-code-reviews.appspot.com/331802/diff/1/6
File
user/test/com/google/gwt/dev/jjs/scriptonly/ScriptOnlyWithNestedClassesTest.java
(right):

http://gwt-code-reviews.appspot.com/331802/diff/1/6#newcode1
user/test/com/google/gwt/dev/jjs/scriptonly/ScriptOnlyWithNestedClassesTest.java:1:
// Copyright 2010 Google Inc. All Rights Reserved.
Wrong copyright block.

http://gwt-code-reviews.appspot.com/331802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to