LGTM with a couple of questions

http://gwt-code-reviews.appspot.com/331802/diff/9001/10001
File dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java
(right):

http://gwt-code-reviews.appspot.com/331802/diff/9001/10001#newcode1266
dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java:1266: }
else if (className.contains("$")) {
Won't this match anonymous inner classes and compiler-synthesized
classes as well?

http://gwt-code-reviews.appspot.com/331802/diff/9001/10003
File
user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/scriptonly/ScriptOnlyWithNestedClasses.java
(right):

http://gwt-code-reviews.appspot.com/331802/diff/9001/10003#newcode86
user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/scriptonly/ScriptOnlyWithNestedClasses.java:86:
public static final Object UNRELATED_ANONYMOUS_CLASS = new Object() {
How about testing other compiler-synthesized classes, such as Enum's
with method overrides?

http://gwt-code-reviews.appspot.com/331802/diff/9001/10004
File
user/test/com/google/gwt/dev/jjs/scriptonly/ScriptOnlyWithNestedClasses.java
(right):

http://gwt-code-reviews.appspot.com/331802/diff/9001/10004#newcode96
user/test/com/google/gwt/dev/jjs/scriptonly/ScriptOnlyWithNestedClasses.java:96:
* referenced from this method doesn't exist in the web mode.
I don't understand this comment -- can you explain what yuo mean by
having it at the end of the class?

http://gwt-code-reviews.appspot.com/331802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to