Thanks for looking, guys. Submitting these fixes.
http://gwt-code-reviews.appspot.com/389802/diff/11/4001 File /bikeshed/src/com/google/gwt/app/place/Activity.java (right): http://gwt-code-reviews.appspot.com/389802/diff/11/4001#newcode49 /bikeshed/src/com/google/gwt/app/place/Activity.java:49: * received), receiver should present it via {...@link Display#widgetIsReady}. On 2010/04/28 22:53:35, cromwellian wrote:
There's no widgetIsReady() method in this interface.
Done. http://gwt-code-reviews.appspot.com/389802/diff/11/4001#newcode49 /bikeshed/src/com/google/gwt/app/place/Activity.java:49: * received), receiver should present it via {...@link Display#widgetIsReady}. On 2010/04/28 22:53:35, cromwellian wrote:
There's no widgetIsReady() method in this interface.
Done. http://gwt-code-reviews.appspot.com/389802/diff/11/4001#newcode50 /bikeshed/src/com/google/gwt/app/place/Activity.java:50: * On 2010/04/28 21:28:19, amitmanjhi wrote:
Stale comment? showActivityWidget instead of widgetIsReady
Done. http://gwt-code-reviews.appspot.com/389802/diff/11/4002 File /bikeshed/src/com/google/gwt/app/place/ActivityManager.java (right): http://gwt-code-reviews.appspot.com/389802/diff/11/4002#newcode65 /bikeshed/src/com/google/gwt/app/place/ActivityManager.java:65: onCancel means you might as well stop getting ready to display, because you never will. It happens in the window between start() and before the activity has responded with showActivityWidget. onStop is called when you have had a chance to display, to let you know you've been torn down. You'll never receive both. http://gwt-code-reviews.appspot.com/389802/diff/11/4002#newcode83 /bikeshed/src/com/google/gwt/app/place/ActivityManager.java:83: * that can maintain our startingNew state. On 2010/04/28 22:53:35, cromwellian wrote:
startingNew? you mean startingNext?
Done. http://gwt-code-reviews.appspot.com/389802/diff/11/4004 File /bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeDetailsActivity.java (right): http://gwt-code-reviews.appspot.com/389802/diff/11/4004#newcode56 /bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeDetailsActivity.java:56: The next patch nukes this field entirely, so I'm not going to mess with it. http://gwt-code-reviews.appspot.com/389802/diff/11/4009 File /bikeshed/test/com/google/gwt/app/place/ActivityManagerTest.java (right): http://gwt-code-reviews.appspot.com/389802/diff/11/4009#newcode116 /bikeshed/test/com/google/gwt/app/place/ActivityManagerTest.java:116: manager.setDisplay(null); On 2010/04/28 21:28:19, amitmanjhi wrote:
unnecessary?
Done. http://gwt-code-reviews.appspot.com/389802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
