http://gwt-code-reviews.appspot.com/508801/diff/1/6 File /user/src/com/google/gwt/logging/client/LoggingPopup.java (right):
http://gwt-code-reviews.appspot.com/508801/diff/1/6#newcode50 /user/src/com/google/gwt/logging/client/LoggingPopup.java:50: MouseUpHandler, MouseDownHandler { I understand the need to drag and resize the panel, and the lack of a standard widget for this, but I hate to see all this custom drag/drop code here. Also, does all of this work in both quirks and standard mode in supported browsers? Would it make sense to use the existing drag/drop functionality of DialogBox and only add resizing here? http://gwt-code-reviews.appspot.com/508801/diff/1/6#newcode137 /user/src/com/google/gwt/logging/client/LoggingPopup.java:137: // library, styling for this window is done pretty manually. Have you verified styling in both standards and quirks mode in all supported browsers? http://gwt-code-reviews.appspot.com/508801/diff/1/6#newcode141 /user/src/com/google/gwt/logging/client/LoggingPopup.java:141: mainPanel.getElement().setAttribute("style", "background-color:white"); mainPanel.getElement().getStyle().setBackgroundColor("white"); http://gwt-code-reviews.appspot.com/508801/diff/1/6#newcode143 /user/src/com/google/gwt/logging/client/LoggingPopup.java:143: final HTML titleBar = new HTML("<center><b>Logging</b></center>"); IIRC, <center> is deprecated. Does it still work in standards mode with a strict DOCTYPE? http://gwt-code-reviews.appspot.com/508801/diff/1/6#newcode151 /user/src/com/google/gwt/logging/client/LoggingPopup.java:151: scrollPanel.setPixelSize(300, 200); Might need to be set these values relative to the available window size, which may be small (mobile) in some cases, or large (developer desktop), in which case you may want it bigger by default. Perhaps set the size in absolute pixels, but calculate based on current window size. http://gwt-code-reviews.appspot.com/508801/diff/1/6#newcode158 /user/src/com/google/gwt/logging/client/LoggingPopup.java:158: final Button maxmin = new Button("Minimize"); For i18n suggest simple ASCII art: Minimize --> >< Maximize --> <> http://gwt-code-reviews.appspot.com/508801/diff/1/6#newcode176 /user/src/com/google/gwt/logging/client/LoggingPopup.java:176: resizeIcon.setHorizontalAlignment(HasHorizontalAlignment.ALIGN_RIGHT); Add comment to indicate name of this unicode character http://gwt-code-reviews.appspot.com/508801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
