Comments Addressed
http://gwt-code-reviews.appspot.com/508801/diff/1/6
File /user/src/com/google/gwt/logging/client/LoggingPopup.java (right):
http://gwt-code-reviews.appspot.com/508801/diff/1/6#newcode50
/user/src/com/google/gwt/logging/client/LoggingPopup.java:50:
MouseUpHandler, MouseDownHandler {
On 2010/05/12 19:38:26, fredsa wrote:
I understand the need to drag and resize the panel, and the lack of a
standard
widget for this, but I hate to see all this custom drag/drop code
here.
Also, does all of this work in both quirks and standard mode in
supported
browsers?
Would it make sense to use the existing drag/drop functionality of
DialogBox and
only add resizing here?
That's the way this was originally written, but I ran into 2 problems. 1
- I couldn't add anything to that top panel (in the end, I put the
minimize button at the bottom anyway, but this implementation leaves me
the option of changing it if I want to) and 2 - Making a border around
the entire popup with the correct outlines was a pain. In the end, the
only additional code to support drag as well as resize is the
WindowMoveHandler (which only has a single 2-line function). If I used
a DialogBox, I'd still need all of the code in this base class for
WindowResizeHandler.
http://gwt-code-reviews.appspot.com/508801/diff/1/6#newcode137
/user/src/com/google/gwt/logging/client/LoggingPopup.java:137: //
library, styling for this window is done pretty manually.
On 2010/05/12 19:38:26, fredsa wrote:
Have you verified styling in both standards and quirks mode in all
supported
browsers?
Working on that now - will send confirmation when done (along with a
separate patch with any required fixes)
http://gwt-code-reviews.appspot.com/508801/diff/1/6#newcode141
/user/src/com/google/gwt/logging/client/LoggingPopup.java:141:
mainPanel.getElement().setAttribute("style", "background-color:white");
On 2010/05/12 19:38:26, fredsa wrote:
mainPanel.getElement().getStyle().setBackgroundColor("white");
Done.
http://gwt-code-reviews.appspot.com/508801/diff/1/6#newcode143
/user/src/com/google/gwt/logging/client/LoggingPopup.java:143: final
HTML titleBar = new HTML("<center><b>Logging</b></center>");
On 2010/05/12 19:38:26, fredsa wrote:
IIRC, <center> is deprecated. Does it still work in standards mode
with a strict
DOCTYPE?
Replaced with <div align=center>
http://gwt-code-reviews.appspot.com/508801/diff/1/6#newcode151
/user/src/com/google/gwt/logging/client/LoggingPopup.java:151:
scrollPanel.setPixelSize(300, 200);
On 2010/05/12 19:38:26, fredsa wrote:
Might need to be set these values relative to the available window
size, which
may be small (mobile) in some cases, or large (developer desktop), in
which case
you may want it bigger by default. Perhaps set the size in absolute
pixels, but
calculate based on current window size.
Done.
http://gwt-code-reviews.appspot.com/508801/diff/1/6#newcode158
/user/src/com/google/gwt/logging/client/LoggingPopup.java:158: final
Button maxmin = new Button("Minimize");
On 2010/05/12 19:38:26, fredsa wrote:
For i18n suggest simple ASCII art:
Minimize --> ><
Maximize --> <>
Done.
http://gwt-code-reviews.appspot.com/508801/diff/1/6#newcode176
/user/src/com/google/gwt/logging/client/LoggingPopup.java:176:
resizeIcon.setHorizontalAlignment(HasHorizontalAlignment.ALIGN_RIGHT);
On 2010/05/12 19:38:26, fredsa wrote:
Add comment to indicate name of this unicode character
Done.
http://gwt-code-reviews.appspot.com/508801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
