Revision: 8127
Author: [email protected]
Date: Thu May 13 07:11:57 2010
Log: Stop trying to be clever on delete, it breaks things
Review at http://gwt-code-reviews.appspot.com/522801

Review by: [email protected]
http://code.google.com/p/google-web-toolkit/source/detail?r=8127

Modified:
/branches/2.1/bikeshed/src/com/google/gwt/valuestore/ui/AbstractRecordListActivity.java

=======================================
--- /branches/2.1/bikeshed/src/com/google/gwt/valuestore/ui/AbstractRecordListActivity.java Wed May 12 17:53:17 2010 +++ /branches/2.1/bikeshed/src/com/google/gwt/valuestore/ui/AbstractRecordListActivity.java Thu May 13 07:11:57 2010
@@ -36,9 +36,9 @@
  * Subclasses must:
  *
  * <ul>
- * <li>implement a method for creating request objects
+ * <li>implement methods to provide a full count, and request a specific
  * <li>provide a {...@link RecordListView}
- * <li>respond to "show" and "edit" requests
+ * <li>respond to "show details" commands
  * </ul>
  *
  * Only the properties required by the view will be requested.
@@ -147,7 +147,7 @@
         break;

       case DELETE:
-        delete(record);
+        init();
         break;

       case CREATE:
@@ -170,13 +170,6 @@

   protected abstract void showDetails(R record);

-  private void delete(R record) {
-    Integer row = recordToRow.get(record.getId());
-    if (row != null) {
-      onRangeChanged(view.asPagingListView());
-    }
-  }
-
   private void getLastPage() {
     fireCountRequest(new Receiver<Long>() {
       public void onSuccess(Long response) {

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to