Reviewers: amitmanjhi,
Description:
Breaks the circular dependencies between app, user, valuestore and
requestfactory. Does so by eliminating the app.util package by:
* moving IsWidget to com.google.gwt.user.client.ui
* moving everything else, all of which is rendering and parsing
related, to a new package, com.google.gwt.input
and by moving the WriteOperations enum out of the RequestFactory
interface and into ValueStore.
Also pares down the inherits lines in ValueStore and RequestFactory to
make it clearer exactly what those modules require from the rest of
GWT.
Review by: amitman...@google.com
Please review this at http://gwt-code-reviews.appspot.com/522803/show
Affected files:
M /bikeshed/src/com/google/gwt/app/client/CellListPlacePickerView.java
M /bikeshed/src/com/google/gwt/app/place/Activity.java
M /bikeshed/src/com/google/gwt/app/place/ActivityManager.java
M /bikeshed/src/com/google/gwt/app/place/PlacePicker.java
M /bikeshed/src/com/google/gwt/app/place/PlacePickerView.java
D /bikeshed/src/com/google/gwt/app/util/BooleanParser.java
D /bikeshed/src/com/google/gwt/app/util/BooleanRenderer.java
D /bikeshed/src/com/google/gwt/app/util/DateTimeFormatRenderer.java
D /bikeshed/src/com/google/gwt/app/util/DoubleParser.java
D /bikeshed/src/com/google/gwt/app/util/DoubleRenderer.java
D /bikeshed/src/com/google/gwt/app/util/IntegerParser.java
D /bikeshed/src/com/google/gwt/app/util/IntegerRenderer.java
D /bikeshed/src/com/google/gwt/app/util/IsWidget.java
D /bikeshed/src/com/google/gwt/app/util/LongParser.java
D /bikeshed/src/com/google/gwt/app/util/LongRenderer.java
D /bikeshed/src/com/google/gwt/app/util/ParseException.java
D /bikeshed/src/com/google/gwt/app/util/Parser.java
D /bikeshed/src/com/google/gwt/app/util/PassthroughParser.java
D /bikeshed/src/com/google/gwt/app/util/PassthroughRenderer.java
D /bikeshed/src/com/google/gwt/app/util/Renderer.java
D /bikeshed/src/com/google/gwt/app/util/package.html
A /bikeshed/src/com/google/gwt/input/Input.gwt.xml
A /bikeshed/src/com/google/gwt/input/shared/BooleanParser.java
A /bikeshed/src/com/google/gwt/input/shared/BooleanRenderer.java
A /bikeshed/src/com/google/gwt/input/shared/DateTimeFormatRenderer.java
A /bikeshed/src/com/google/gwt/input/shared/DoubleParser.java
A /bikeshed/src/com/google/gwt/input/shared/DoubleRenderer.java
A /bikeshed/src/com/google/gwt/input/shared/IntegerParser.java
A /bikeshed/src/com/google/gwt/input/shared/IntegerRenderer.java
A /bikeshed/src/com/google/gwt/input/shared/LongParser.java
A /bikeshed/src/com/google/gwt/input/shared/LongRenderer.java
A /bikeshed/src/com/google/gwt/input/shared/ParseException.java
A /bikeshed/src/com/google/gwt/input/shared/Parser.java
A /bikeshed/src/com/google/gwt/input/shared/PassthroughParser.java
A /bikeshed/src/com/google/gwt/input/shared/PassthroughRenderer.java
A /bikeshed/src/com/google/gwt/input/shared/Renderer.java
M /bikeshed/src/com/google/gwt/requestfactory/RequestFactory.gwt.xml
M
/bikeshed/src/com/google/gwt/requestfactory/client/impl/RequestFactoryJsonImpl.java
M
/bikeshed/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java
M
/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java
M
/bikeshed/src/com/google/gwt/requestfactory/server/SampleDataPopulator.java
M /bikeshed/src/com/google/gwt/requestfactory/shared/RequestFactory.java
M
/bikeshed/src/com/google/gwt/requestfactory/shared/impl/RequestDataManager.java
M /bikeshed/src/com/google/gwt/sample/expenses/gwt/client/Scaffold.java
M
/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ScaffoldMobile.java
M
/bikeshed/src/com/google/gwt/sample/expenses/gwt/request/EmployeeRecordChanged.java
M
/bikeshed/src/com/google/gwt/sample/expenses/gwt/request/ExpenseRecordChanged.java
M
/bikeshed/src/com/google/gwt/sample/expenses/gwt/request/ReportRecordChanged.java
M
/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/ScaffoldListPlaceRenderer.java
M
/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/report/ReportListView.java
M /bikeshed/src/com/google/gwt/sample/expenses/server/DataGenerator.java
M /bikeshed/src/com/google/gwt/user/User.gwt.xml
M /bikeshed/src/com/google/gwt/user/client/ui/DoubleBox.java
M /bikeshed/src/com/google/gwt/user/client/ui/IntegerBox.java
A /bikeshed/src/com/google/gwt/user/client/ui/IsWidget.java
M /bikeshed/src/com/google/gwt/user/client/ui/LongBox.java
M /bikeshed/src/com/google/gwt/user/client/ui/TextBoxBase.java
M /bikeshed/src/com/google/gwt/user/client/ui/ValueBox.java
M /bikeshed/src/com/google/gwt/user/client/ui/ValueBoxBase.java
M /bikeshed/src/com/google/gwt/valuestore/ValueStore.gwt.xml
M
/bikeshed/src/com/google/gwt/valuestore/client/DeltaValueStoreJsonImpl.java
M /bikeshed/src/com/google/gwt/valuestore/client/ValueStoreJsonImpl.java
M /bikeshed/src/com/google/gwt/valuestore/shared/RecordChangedEvent.java
A /bikeshed/src/com/google/gwt/valuestore/shared/WriteOperation.java
M /bikeshed/src/com/google/gwt/valuestore/shared/impl/RecordSchema.java
M
/bikeshed/src/com/google/gwt/valuestore/ui/AbstractRecordListActivity.java
M /bikeshed/src/com/google/gwt/valuestore/ui/PropertyColumn.java
M /bikeshed/src/com/google/gwt/valuestore/ui/RecordDetailsView.java
M /bikeshed/src/com/google/gwt/valuestore/ui/RecordEditView.java
M /bikeshed/src/com/google/gwt/valuestore/ui/RecordListView.java
M /bikeshed/test/com/google/gwt/app/place/ActivityManagerTest.java
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
