LGTM

nit: there are a few *.java files which have inconsistent use of blank
lines


http://gwt-code-reviews.appspot.com/641801/diff/1/9
File
samples/logexample/src/com/google/gwt/sample/logexample/client/CustomLogArea.java
(right):

http://gwt-code-reviews.appspot.com/641801/diff/1/9#newcode30
samples/logexample/src/com/google/gwt/sample/logexample/client/CustomLogArea.java:30:
* WRITE ME
Write me :)

http://gwt-code-reviews.appspot.com/641801/diff/1/10
File
samples/logexample/src/com/google/gwt/sample/logexample/client/CustomLogArea.ui.xml
(right):

http://gwt-code-reviews.appspot.com/641801/diff/1/10#newcode5
samples/logexample/src/com/google/gwt/sample/logexample/client/CustomLogArea.ui.xml:5:
multiple add calls can be used by the HasWidgetsLogHandler. Here we've
add -> add()

http://gwt-code-reviews.appspot.com/641801/diff/1/11
File
samples/logexample/src/com/google/gwt/sample/logexample/client/HandlerController.java
(right):

http://gwt-code-reviews.appspot.com/641801/diff/1/11#newcode39
samples/logexample/src/com/google/gwt/sample/logexample/client/HandlerController.java:39:
* WRITE ME
Write me

http://gwt-code-reviews.appspot.com/641801/diff/1/11#newcode90
samples/logexample/src/com/google/gwt/sample/logexample/client/HandlerController.java:90:
setupHandler("not implemented", remoteCheckbox);
Should this line just be commented out instead?

http://gwt-code-reviews.appspot.com/641801/diff/1/15
File
samples/logexample/src/com/google/gwt/sample/logexample/client/LoggerController.java
(right):

http://gwt-code-reviews.appspot.com/641801/diff/1/15#newcode29
samples/logexample/src/com/google/gwt/sample/logexample/client/LoggerController.java:29:
* WRITE ME
write me

http://gwt-code-reviews.appspot.com/641801/diff/1/17
File
samples/logexample/src/com/google/gwt/sample/logexample/client/OneLoggerController.java
(right):

http://gwt-code-reviews.appspot.com/641801/diff/1/17#newcode34
samples/logexample/src/com/google/gwt/sample/logexample/client/OneLoggerController.java:34:
* WRITE ME
write me

http://gwt-code-reviews.appspot.com/641801/diff/1/19
File
samples/logexample/src/com/google/gwt/sample/logexample/client/ServerLoggingArea.java
(right):

http://gwt-code-reviews.appspot.com/641801/diff/1/19#newcode34
samples/logexample/src/com/google/gwt/sample/logexample/client/ServerLoggingArea.java:34:
* WRITE ME
write me

http://gwt-code-reviews.appspot.com/641801/diff/1/19#newcode53
samples/logexample/src/com/google/gwt/sample/logexample/client/ServerLoggingArea.java:53:
SharedLoggingLibrary.logUsingSharedLibrary(Level.SEVERE, "FOO");
Change "FOO" to something more descriptive

http://gwt-code-reviews.appspot.com/641801/diff/1/24
File
samples/logexample/src/com/google/gwt/sample/logexample/shared/SharedLoggingLibrary.java
(right):

http://gwt-code-reviews.appspot.com/641801/diff/1/24#newcode23
samples/logexample/src/com/google/gwt/sample/logexample/shared/SharedLoggingLibrary.java:23:
* WRITE ME
write me

http://gwt-code-reviews.appspot.com/641801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to