http://gwt-code-reviews.appspot.com/641801/diff/1/9 File samples/logexample/src/com/google/gwt/sample/logexample/client/CustomLogArea.java (right):
http://gwt-code-reviews.appspot.com/641801/diff/1/9#newcode30 samples/logexample/src/com/google/gwt/sample/logexample/client/CustomLogArea.java:30: * WRITE ME On 2010/06/18 17:21:55, fredsa wrote:
Write me :)
Done. http://gwt-code-reviews.appspot.com/641801/diff/1/10 File samples/logexample/src/com/google/gwt/sample/logexample/client/CustomLogArea.ui.xml (right): http://gwt-code-reviews.appspot.com/641801/diff/1/10#newcode5 samples/logexample/src/com/google/gwt/sample/logexample/client/CustomLogArea.ui.xml:5: multiple add calls can be used by the HasWidgetsLogHandler. Here we've On 2010/06/18 17:21:55, fredsa wrote:
add -> add()
Done. http://gwt-code-reviews.appspot.com/641801/diff/1/11 File samples/logexample/src/com/google/gwt/sample/logexample/client/HandlerController.java (right): http://gwt-code-reviews.appspot.com/641801/diff/1/11#newcode39 samples/logexample/src/com/google/gwt/sample/logexample/client/HandlerController.java:39: * WRITE ME On 2010/06/18 17:21:55, fredsa wrote:
Write me
Done. http://gwt-code-reviews.appspot.com/641801/diff/1/11#newcode90 samples/logexample/src/com/google/gwt/sample/logexample/client/HandlerController.java:90: setupHandler("not implemented", remoteCheckbox); On 2010/06/18 17:21:55, fredsa wrote:
Should this line just be commented out instead?
I wanted there to be one disabled handler on the page, but you're right - this one is confusing. I removed it, and disable the firebug handler by default instead in the gwt.xml file. http://gwt-code-reviews.appspot.com/641801/diff/1/15 File samples/logexample/src/com/google/gwt/sample/logexample/client/LoggerController.java (right): http://gwt-code-reviews.appspot.com/641801/diff/1/15#newcode29 samples/logexample/src/com/google/gwt/sample/logexample/client/LoggerController.java:29: * WRITE ME On 2010/06/18 17:21:55, fredsa wrote:
write me
Done. http://gwt-code-reviews.appspot.com/641801/diff/1/17 File samples/logexample/src/com/google/gwt/sample/logexample/client/OneLoggerController.java (right): http://gwt-code-reviews.appspot.com/641801/diff/1/17#newcode34 samples/logexample/src/com/google/gwt/sample/logexample/client/OneLoggerController.java:34: * WRITE ME On 2010/06/18 17:21:55, fredsa wrote:
write me
Done. http://gwt-code-reviews.appspot.com/641801/diff/1/19 File samples/logexample/src/com/google/gwt/sample/logexample/client/ServerLoggingArea.java (right): http://gwt-code-reviews.appspot.com/641801/diff/1/19#newcode34 samples/logexample/src/com/google/gwt/sample/logexample/client/ServerLoggingArea.java:34: * WRITE ME On 2010/06/18 17:21:55, fredsa wrote:
write me
Done. http://gwt-code-reviews.appspot.com/641801/diff/1/19#newcode53 samples/logexample/src/com/google/gwt/sample/logexample/client/ServerLoggingArea.java:53: SharedLoggingLibrary.logUsingSharedLibrary(Level.SEVERE, "FOO"); On 2010/06/18 17:21:55, fredsa wrote:
Change "FOO" to something more descriptive
Done. http://gwt-code-reviews.appspot.com/641801/diff/1/24 File samples/logexample/src/com/google/gwt/sample/logexample/shared/SharedLoggingLibrary.java (right): http://gwt-code-reviews.appspot.com/641801/diff/1/24#newcode23 samples/logexample/src/com/google/gwt/sample/logexample/shared/SharedLoggingLibrary.java:23: * WRITE ME On 2010/06/18 17:21:55, fredsa wrote:
write me
Done. http://gwt-code-reviews.appspot.com/641801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
