Joel, after chatting it over with Amit I'm going to go ahead and submit this (once I fix a broken test), just to unblock the effort to get rid of the bikeshed. Please do still review it.
On Fri, Jun 18, 2010 at 3:18 PM, Amit Manjhi <[email protected]> wrote: > LGTM > > On Fri, Jun 18, 2010 at 3:11 PM, <[email protected]> wrote: > > Reviewers: amitmanjhi, jgw, > > > > Description: > > Introduces com.google.gwt.text from bikeshed, along with changes in > > com.google.gwt.user.client.ui to take advantage of it. This is another > > step toward getting rid of the bikeshed. > > > > Note in particular the new TextBox-like widget ValueBox, which > > required refactoring a new abstract superclass ValueBoxBase out of > > TextBoxBase. > > > > A smaller change to note is the introduction of TakesValue as a > > slimmer super-interface for HasValue which doesn't require being an > > event source. The Editor framework is expected to take advantage of > > this, although that may still change a bit. > > > > Items that are still half-baked (IsWidget, BooleanParser, > > BooleanValueBox, etc.) have been moved to com.google.gwt.app rather > > than text or user. This required moving some classes (e.g. the various > > Record*View interfaces) from valuestore to app, to avoid cirular > > dependencies. > > > > > > Please review this at http://gwt-code-reviews.appspot.com/649801/show > > > > Affected files: > > A bikeshed/src/com/google/gwt/app/client/BooleanParser.java > > A bikeshed/src/com/google/gwt/app/client/BooleanRenderer.java > > M bikeshed/src/com/google/gwt/app/client/CellListPlacePickerView.java > > A bikeshed/src/com/google/gwt/app/client/DoubleBox.java > > A bikeshed/src/com/google/gwt/app/client/DoubleParser.java > > A bikeshed/src/com/google/gwt/app/client/DoubleRenderer.java > > M bikeshed/src/com/google/gwt/app/client/EditorSupport.java > > A bikeshed/src/com/google/gwt/app/client/IntegerBox.java > > A bikeshed/src/com/google/gwt/app/client/IntegerParser.java > > A bikeshed/src/com/google/gwt/app/client/IntegerRenderer.java > > A bikeshed/src/com/google/gwt/app/client/LongBox.java > > A bikeshed/src/com/google/gwt/app/client/LongParser.java > > A bikeshed/src/com/google/gwt/app/client/LongRenderer.java > > M bikeshed/src/com/google/gwt/app/place/AbstractRecordEditActivity.java > > M bikeshed/src/com/google/gwt/app/place/AbstractRecordListActivity.java > > A bikeshed/src/com/google/gwt/app/place/AbstractRecordListView.java > > M bikeshed/src/com/google/gwt/app/place/Activity.java > > M bikeshed/src/com/google/gwt/app/place/ActivityManager.java > > A bikeshed/src/com/google/gwt/app/place/IsWidget.java > > M bikeshed/src/com/google/gwt/app/place/PlacePicker.java > > M bikeshed/src/com/google/gwt/app/place/PlacePickerView.java > > A bikeshed/src/com/google/gwt/app/place/PropertyColumn.java > > A bikeshed/src/com/google/gwt/app/place/PropertyView.java > > A bikeshed/src/com/google/gwt/app/place/RecordDetailsView.java > > A bikeshed/src/com/google/gwt/app/place/RecordEditView.java > > A bikeshed/src/com/google/gwt/app/place/RecordListView.java > > D bikeshed/src/com/google/gwt/input/Input.gwt.xml > > D bikeshed/src/com/google/gwt/input/shared/BooleanParser.java > > D bikeshed/src/com/google/gwt/input/shared/BooleanRenderer.java > > D bikeshed/src/com/google/gwt/input/shared/DateTimeFormatRenderer.java > > D bikeshed/src/com/google/gwt/input/shared/DoubleParser.java > > D bikeshed/src/com/google/gwt/input/shared/DoubleRenderer.java > > D bikeshed/src/com/google/gwt/input/shared/IntegerParser.java > > D bikeshed/src/com/google/gwt/input/shared/IntegerRenderer.java > > D bikeshed/src/com/google/gwt/input/shared/LongParser.java > > D bikeshed/src/com/google/gwt/input/shared/LongRenderer.java > > D bikeshed/src/com/google/gwt/input/shared/ParseException.java > > D bikeshed/src/com/google/gwt/input/shared/Parser.java > > D bikeshed/src/com/google/gwt/input/shared/PassthroughParser.java > > D bikeshed/src/com/google/gwt/input/shared/PassthroughRenderer.java > > D bikeshed/src/com/google/gwt/input/shared/Renderer.java > > M bikeshed/src/com/google/gwt/sample/expenses/gwt/client/Scaffold.java > > M > > > bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ScaffoldMobile.java > > M > > > bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/ScaffoldListPlaceRenderer.java > > M > > > bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeDetailsActivity.java > > M > > > bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeDetailsView.java > > M > > > bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeEditActivity.java > > M > > > bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeEditView.java > > M > > > bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeListActivity.java > > M > > > bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeListView.java > > M > > > bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/report/ReportDetailsActivity.java > > M > > > bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/report/ReportDetailsView.java > > M > > > bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/report/ReportEditActivity.java > > M > > > bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/report/ReportEditView.java > > M > > > bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/report/ReportListActivity.java > > M > > > bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/report/ReportListView.java > > D bikeshed/src/com/google/gwt/user/User.gwt.xml > > D bikeshed/src/com/google/gwt/user/client/ui/DoubleBox.java > > D bikeshed/src/com/google/gwt/user/client/ui/HasValue.java > > D bikeshed/src/com/google/gwt/user/client/ui/IntegerBox.java > > D bikeshed/src/com/google/gwt/user/client/ui/IsWidget.java > > D bikeshed/src/com/google/gwt/user/client/ui/LongBox.java > > D bikeshed/src/com/google/gwt/user/client/ui/TakesValue.java > > D bikeshed/src/com/google/gwt/user/client/ui/TextBoxBase.java > > D bikeshed/src/com/google/gwt/user/client/ui/ValueBox.java > > D bikeshed/src/com/google/gwt/user/client/ui/ValueBoxBase.java > > D bikeshed/src/com/google/gwt/user/client/ui/package.html > > D bikeshed/src/com/google/gwt/valuestore/ui/AbstractRecordListView.java > > D bikeshed/src/com/google/gwt/valuestore/ui/PropertyColumn.java > > D bikeshed/src/com/google/gwt/valuestore/ui/PropertyView.java > > D bikeshed/src/com/google/gwt/valuestore/ui/RecordDetailsView.java > > D bikeshed/src/com/google/gwt/valuestore/ui/RecordEditView.java > > D bikeshed/src/com/google/gwt/valuestore/ui/RecordListView.java > > M bikeshed/test/com/google/gwt/app/place/ActivityManagerTest.java > > A user/src/com/google/gwt/i18n/client/DateTimeFormatRenderer.java > > A user/src/com/google/gwt/text/Text.gwt.xml > > A user/src/com/google/gwt/text/shared/AbstractRenderer.java > > A user/src/com/google/gwt/text/shared/Parser.java > > A user/src/com/google/gwt/text/shared/PassthroughParser.java > > A user/src/com/google/gwt/text/shared/PassthroughRenderer.java > > A user/src/com/google/gwt/text/shared/Renderer.java > > M user/src/com/google/gwt/user/User.gwt.xml > > M user/src/com/google/gwt/user/client/ui/HasValue.java > > A user/src/com/google/gwt/user/client/ui/TakesValue.java > > M user/src/com/google/gwt/user/client/ui/TextBoxBase.java > > A user/src/com/google/gwt/user/client/ui/ValueBox.java > > A user/src/com/google/gwt/user/client/ui/ValueBoxBase.java > > A user/super/com/google/gwt/emul/java/text/ParseException.java > > > > > > > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
