http://gwt-code-reviews.appspot.com/646803/diff/1/15
File user/src/com/google/gwt/dom/client/WebSocket.java (right):

http://gwt-code-reviews.appspot.com/646803/diff/1/15#newcode16
user/src/com/google/gwt/dom/client/WebSocket.java:16: package
com.google.gwt.dom.client;
+1

http://gwt-code-reviews.appspot.com/646803/diff/1/16
File user/src/com/google/gwt/dom/client/WebSocketCloseHandler.java
(right):

http://gwt-code-reviews.appspot.com/646803/diff/1/16#newcode22
user/src/com/google/gwt/dom/client/WebSocketCloseHandler.java:22: void
onClose(CloseEvent event);
+1/2

I though we said that we would have a parallel hierarchy of events.

That being said, I'm not exactly sure what the logical wrapper buys us.
We used logical wrappers around NativeEvent because NativeEvent is a
dumping ground of methods, so the logical events limit the API to the
applicable methods.  Since the "native" web socket events are already
limited, I'm not sure we need the logical event.  We might need them to
define the TYPE, which is required to use the EventHandler mechanism in
GWT.

http://gwt-code-reviews.appspot.com/646803/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to