http://gwt-code-reviews.appspot.com/646803/diff/1/16
File user/src/com/google/gwt/dom/client/WebSocketCloseHandler.java
(right):

http://gwt-code-reviews.appspot.com/646803/diff/1/16#newcode22
user/src/com/google/gwt/dom/client/WebSocketCloseHandler.java:22: void
onClose(CloseEvent event);
I think CloseEvent specifically doesn't buy anything. I also think it
could be easily modeled by just using nativeEvent but there are 3 other
events - error, open, message. MessageEvent contains some specific
information not found in other events.

I think the model with 4 events (even though it might be almost dead
code in the other 3 events) is much more intuitive and reflects much
better the WebSockets browser API.

http://gwt-code-reviews.appspot.com/646803/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to