Couple of questions.

http://gwt-code-reviews.appspot.com/698801/diff/8001/9002
File user/src/com/google/gwt/app/place/AbstractRecordEditActivity.java
(right):

http://gwt-code-reviews.appspot.com/698801/diff/8001/9002#newcode73
user/src/com/google/gwt/app/place/AbstractRecordEditActivity.java:73:
return "Are you sure you want to abandon your changes?";
Extract this string to a protected method?

http://gwt-code-reviews.appspot.com/698801/diff/8001/9006
File user/src/com/google/gwt/app/place/PlaceChangeRequestedEvent.java
(right):

http://gwt-code-reviews.appspot.com/698801/diff/8001/9006#newcode88
user/src/com/google/gwt/app/place/PlaceChangeRequestedEvent.java:88:
public void setWarning(String warning) {
Are multiple warnings something that needs to be supported?

http://gwt-code-reviews.appspot.com/698801/diff/8001/9007
File user/src/com/google/gwt/app/place/PlaceController.java (right):

http://gwt-code-reviews.appspot.com/698801/diff/8001/9007#newcode45
user/src/com/google/gwt/app/place/PlaceController.java:45: return
Window.confirm(message);
Is there something that can be done to prevent the default
implementation from arbitrarily hanging a test?  Maybe a rebind rule in
JUnit.gwt.xml?

http://gwt-code-reviews.appspot.com/698801/diff/8001/9007#newcode69
user/src/com/google/gwt/app/place/PlaceController.java:69:
this(eventBus, new DefaultDelegate());
GWT.create() ?

http://gwt-code-reviews.appspot.com/698801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to