http://gwt-code-reviews.appspot.com/698801/diff/8001/9002
File user/src/com/google/gwt/app/place/AbstractRecordEditActivity.java
(right):
http://gwt-code-reviews.appspot.com/698801/diff/8001/9002#newcode62
user/src/com/google/gwt/app/place/AbstractRecordEditActivity.java:62:
deltas = null; // silence the next willStop() call when place changes
On 2010/07/16 15:57:22, tbroyer wrote:
"silence the next willStop()" should read "silence the next mayStop()"
Done.
http://gwt-code-reviews.appspot.com/698801/diff/8001/9002#newcode73
user/src/com/google/gwt/app/place/AbstractRecordEditActivity.java:73:
return "Are you sure you want to abandon your changes?";
An i18n pass over this stuff is already on the list, out of scope for
this patch.
http://gwt-code-reviews.appspot.com/698801/diff/8001/9006
File user/src/com/google/gwt/app/place/PlaceChangeRequestedEvent.java
(right):
http://gwt-code-reviews.appspot.com/698801/diff/8001/9006#newcode88
user/src/com/google/gwt/app/place/PlaceChangeRequestedEvent.java:88:
public void setWarning(String warning) {
Not in my opinion. And anyway, they aren't feasible for the window
closing case, unless we do something awful like appending them. Which I
suppose we could do…
I'm inclined to say that the multiple cancels case results in arbitrary
output, since that's all we've offered internally for quite a while and
no one has complained.
http://gwt-code-reviews.appspot.com/698801/diff/8001/9007
File user/src/com/google/gwt/app/place/PlaceController.java (right):
http://gwt-code-reviews.appspot.com/698801/diff/8001/9007#newcode45
user/src/com/google/gwt/app/place/PlaceController.java:45: return
Window.confirm(message);
Seems like following your GWT.create suggestion, and the existence of
the delegate hook itself are enough protection. Adding the rebind rule
seems like belts, suspenders *and* sansa-belt pants.
http://gwt-code-reviews.appspot.com/698801/diff/8001/9007#newcode69
user/src/com/google/gwt/app/place/PlaceController.java:69:
this(eventBus, new DefaultDelegate());
On 2010/07/16 15:58:45, bobv wrote:
GWT.create() ?
Done, with this JavaDoc:
* Create a new PlaceController with a {...@link DefaultDelegate}.
* The DefaultDelegate is created via a call to GWT.create(), so
* an alternative default implementation can be provided
* <replace-with> rules in a gwt.xml file.
http://gwt-code-reviews.appspot.com/698801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
