Some comments.

http://gwt-code-reviews.appspot.com/703801/diff/1/2
File user/src/com/google/gwt/uibinder/elementparsers/GridParser.java
(right):

http://gwt-code-reviews.appspot.com/703801/diff/1/2#newcode2
user/src/com/google/gwt/uibinder/elementparsers/GridParser.java:2: *
Copyright 2009 Google Inc.
It might have been 2009 when this patch was first written, if I remember
correctly... :)

http://gwt-code-reviews.appspot.com/703801/diff/1/2#newcode84
user/src/com/google/gwt/uibinder/elementparsers/GridParser.java:84:
Vector<Vector<CellContent>> matrix = new Vector<Vector<CellContent>>();
This really should be changed. I just had a look about the differences
and it seems that ArrayList might even be faster then vector. I used
this just out of habit. I should have changed that in the first place
but wasn't aware of the speed difference, I thought it's pretty much the
same.

http://gwt-code-reviews.appspot.com/703801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to