http://gwt-code-reviews.appspot.com/703801/diff/1/2 File user/src/com/google/gwt/uibinder/elementparsers/GridParser.java (right):
http://gwt-code-reviews.appspot.com/703801/diff/1/2#newcode2 user/src/com/google/gwt/uibinder/elementparsers/GridParser.java:2: * Copyright 2009 Google Inc. On 2010/07/19 17:14:24, bobv wrote:
Has this code been released before?
Done. http://gwt-code-reviews.appspot.com/703801/diff/1/2#newcode84 user/src/com/google/gwt/uibinder/elementparsers/GridParser.java:84: Vector<Vector<CellContent>> matrix = new Vector<Vector<CellContent>>(); On 2010/07/19 17:14:24, bobv wrote:
Vector and not ArrayList?
Done. http://gwt-code-reviews.appspot.com/703801/diff/1/6 File user/test/com/google/gwt/uibinder/elementparsers/GridParserTest.java (right): http://gwt-code-reviews.appspot.com/703801/diff/1/6#newcode52 user/test/com/google/gwt/uibinder/elementparsers/GridParserTest.java:52: } catch (UnableToCompleteException e) { On 2010/07/19 17:14:24, bobv wrote:
Scott says rename e -> expected for clarity when checking for thrown
exceptions. Done. http://www.bartleby.com/100/420.47.html http://gwt-code-reviews.appspot.com/703801/diff/1/7 File user/test/com/google/gwt/uibinder/test/UiJavaResources.java (right): http://gwt-code-reviews.appspot.com/703801/diff/1/7#newcode108 user/test/com/google/gwt/uibinder/test/UiJavaResources.java:108: }; Nothing else in this class has one. http://gwt-code-reviews.appspot.com/703801/diff/1/10 File user/test/com/google/gwt/uibinder/test/client/WidgetBasedUi.java.rej (right): http://gwt-code-reviews.appspot.com/703801/diff/1/10#newcode1 user/test/com/google/gwt/uibinder/test/client/WidgetBasedUi.java.rej:1: *************** On 2010/07/19 17:14:24, bobv wrote:
Don't commit this file.
Eeep! Thanks. I don't know how these things keep getting into the patches. http://gwt-code-reviews.appspot.com/703801/diff/1/11 File user/test/com/google/gwt/uibinder/test/client/WidgetBasedUi.ui.xml (right): http://gwt-code-reviews.appspot.com/703801/diff/1/11#newcode614 user/test/com/google/gwt/uibinder/test/client/WidgetBasedUi.ui.xml:614: </gwt:customCell> On 2010/07/19 17:14:24, bobv wrote:
Indentation weirdness.
Done. http://gwt-code-reviews.appspot.com/703801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
