LGTM, just nits.
http://gwt-code-reviews.appspot.com/702801/diff/17001/18004 File dev/core/src/com/google/gwt/dev/jjs/impl/ExpressionAnalyzer.java (right): http://gwt-code-reviews.appspot.com/702801/diff/17001/18004#newcode98 dev/core/src/com/google/gwt/dev/jjs/impl/ExpressionAnalyzer.java:98: accessesField = true; BTW: for the accessesField = true, can you add a TODO: do we actually need to set this? http://gwt-code-reviews.appspot.com/702801/diff/17001/18004#newcode158 dev/core/src/com/google/gwt/dev/jjs/impl/ExpressionAnalyzer.java:158: * Eclipse formatter actually adds spaces here, if you wouldn't mind reverting the 3 whitespace delta lines. http://gwt-code-reviews.appspot.com/702801/diff/17001/18006 File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java (right): http://gwt-code-reviews.appspot.com/702801/diff/17001/18006#newcode519 dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java:519: private JsName arrayLength = objectScope.declareName("length"); make 'final' and sort it up between alreadyRan and clinitMap http://gwt-code-reviews.appspot.com/702801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
