http://gwt-code-reviews.appspot.com/702801/diff/17001/18004 File dev/core/src/com/google/gwt/dev/jjs/impl/ExpressionAnalyzer.java (right):
http://gwt-code-reviews.appspot.com/702801/diff/17001/18004#newcode98 dev/core/src/com/google/gwt/dev/jjs/impl/ExpressionAnalyzer.java:98: accessesField = true; On 2010/07/20 21:01:34, scottb wrote:
BTW: for the accessesField = true, can you add a TODO: do we actually
need to
set this?
Done. http://gwt-code-reviews.appspot.com/702801/diff/17001/18004#newcode100 dev/core/src/com/google/gwt/dev/jjs/impl/ExpressionAnalyzer.java:100: canThrowException = true; On 2010/07/20 21:04:25, scottb wrote:
By the way... I just submitted a change to this file:
http://gwt-code-reviews.appspot.com/707801/diff/1/2
When you go and resolve your change against HEAD, please copy my
JFieldRef
change to this line as well, so that you only throw an exception if
the instance
may possibly be null.
Done. http://gwt-code-reviews.appspot.com/702801/diff/17001/18004#newcode158 dev/core/src/com/google/gwt/dev/jjs/impl/ExpressionAnalyzer.java:158: * On 2010/07/20 21:01:34, scottb wrote:
Eclipse formatter actually adds spaces here, if you wouldn't mind
reverting the
3 whitespace delta lines.
Done. http://gwt-code-reviews.appspot.com/702801/diff/17001/18006 File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java (right): http://gwt-code-reviews.appspot.com/702801/diff/17001/18006#newcode519 dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java:519: private JsName arrayLength = objectScope.declareName("length"); On 2010/07/20 21:01:34, scottb wrote:
make 'final' and sort it up between alreadyRan and clinitMap
Done. http://gwt-code-reviews.appspot.com/702801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
