Working on the others, but figured I'd fire these questions back at you while I'm working on them
http://gwt-code-reviews.appspot.com/706802/diff/1/6 File bikeshed/src/com/google/gwt/sample/expenses/gwt/request/UserInformationRecord.java (right): http://gwt-code-reviews.appspot.com/706802/diff/1/6#newcode47 bikeshed/src/com/google/gwt/sample/expenses/gwt/request/UserInformationRecord.java:47: String getUniqueId(); On 2010/07/23 18:14:55, Ray Ryan wrote:
Any reason to provide both this and getId(), which (for now) is
required by the
Record interface anyway?
I didn't fully understand this value, but it looked to me like it was per instance (ie - for cacheing purposes). So if the user changed their nickname, then getId() would return a new value (at least if the persistence was actually working for this class). getUniqueId() however, is for the user themselves, and would not change, even if some aspects of the object (like the nickname) changed. I'm happy to get rid of it if that's not the case - I just wanted to double check first. http://gwt-code-reviews.appspot.com/706802/diff/1/11 File user/src/com/google/gwt/requestfactory/client/AuthenticationFailureHandler.java (right): http://gwt-code-reviews.appspot.com/706802/diff/1/11#newcode47 user/src/com/google/gwt/requestfactory/client/AuthenticationFailureHandler.java:47: String loginUrl = response.getHeader("login"); On 2010/07/23 18:14:55, Ray Ryan wrote:
Where is it documented that this header will be set?
Nowhere :-) Where would you like it documented? http://gwt-code-reviews.appspot.com/706802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
