http://gwt-code-reviews.appspot.com/706802/diff/1/2
File
bikeshed/src/com/google/gwt/sample/expenses/gwt/client/Scaffold.java
(right):
http://gwt-code-reviews.appspot.com/706802/diff/1/2#newcode87
bikeshed/src/com/google/gwt/sample/expenses/gwt/client/Scaffold.java:87:
shell.getLoginPanel().add(login);
On 2010/07/23 18:14:55, Ray Ryan wrote:
Might as well just instantiate the LoginWidget right in the ui.xml.
Give shell
a getLoginWidget method instead of getLoginPanel
Done.
http://gwt-code-reviews.appspot.com/706802/diff/1/9
File
bikeshed/src/com/google/gwt/sample/expenses/server/domain/GaeUserInformation.java
(right):
http://gwt-code-reviews.appspot.com/706802/diff/1/9#newcode28
bikeshed/src/com/google/gwt/sample/expenses/server/domain/GaeUserInformation.java:28:
public class GaeUserInformation extends UserInformation{
On 2010/07/23 18:14:55, Ray Ryan wrote:
Nit: need a space before the {
Done.
http://gwt-code-reviews.appspot.com/706802/diff/1/10
File bikeshed/war/WEB-INF/web.xml (right):
http://gwt-code-reviews.appspot.com/706802/diff/1/10#newcode13
bikeshed/war/WEB-INF/web.xml:13: <param-name>userInfoClass</param-name>
On 2010/07/23 18:14:55, Ray Ryan wrote:
Please be sure to mention this in the RequestFactoryServlet javadoc
(and get rid
of the stale thing there).
Done.
http://gwt-code-reviews.appspot.com/706802/diff/1/12
File user/src/com/google/gwt/requestfactory/client/LoginWidget.java
(right):
http://gwt-code-reviews.appspot.com/706802/diff/1/12#newcode44
user/src/com/google/gwt/requestfactory/client/LoginWidget.java:44:
public void updateWithNewUserInformation(UserInformationProvider info) {
On 2010/07/23 18:14:55, Ray Ryan wrote:
Can you make this setUserInformation? That's more idiomatic.
Done.
http://gwt-code-reviews.appspot.com/706802/diff/1/19
File
user/src/com/google/gwt/requestfactory/shared/UserInformationProvider.java
(right):
http://gwt-code-reviews.appspot.com/706802/diff/1/19#newcode23
user/src/com/google/gwt/requestfactory/shared/UserInformationProvider.java:23:
public interface UserInformationProvider {
On 2010/07/23 18:14:55, Ray Ryan wrote:
Naming nits. Can you rename this interface to UserInformation, and
make your
concrete implementation UserInformationImpl?
Done.
http://gwt-code-reviews.appspot.com/706802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
