Looks good enough for a first pass.  I'll follow up with converting the
UI to UiBinder in preparation for wiring up the editor stuff.


http://gwt-code-reviews.appspot.com/710801/diff/18001/19001
File
bikeshed/src/com/google/gwt/sample/expenses/gwt/request/ExpensesRequestFactory.java
(left):

http://gwt-code-reviews.appspot.com/710801/diff/18001/19001#oldcode50
bikeshed/src/com/google/gwt/sample/expenses/gwt/request/ExpensesRequestFactory.java:50:
// }
Unrelated change.

http://gwt-code-reviews.appspot.com/710801/diff/18001/19023
File
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/shared/PersonRecord.java
(right):

http://gwt-code-reviews.appspot.com/710801/diff/18001/19023#newcode27
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/shared/PersonRecord.java:27:
public interface PersonRecord extends Record {
Rename to PersonProxy.

http://gwt-code-reviews.appspot.com/710801/diff/18001/19028
File
user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java
(right):

http://gwt-code-reviews.appspot.com/710801/diff/18001/19028#newcode244
user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java:244:
for (JMethod method : interfaceType.getMethods()) {
Do you want to use getOverridableMethods() to inherit methods from
super-interfaces?

http://gwt-code-reviews.appspot.com/710801/diff/18001/19028#newcode380
user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java:380:
for (JMethod method : selectorInterface.getMethods()) {
Methods from super-interfaces?

http://gwt-code-reviews.appspot.com/710801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to