LGTM

The problem with this approach is that it's so hugely prescriptive
— there is one and only one way to deal with user auth in
RequestFactory. I think it will do to get the conversation started in
M3, but we'll need to find something more flexible before we ship.


http://gwt-code-reviews.appspot.com/721803/diff/1/7
File
bikeshed/src/com/google/gwt/sample/expenses/server/domain/GaeUserInformation.java
(right):

http://gwt-code-reviews.appspot.com/721803/diff/1/7#newcode72
bikeshed/src/com/google/gwt/sample/expenses/server/domain/GaeUserInformation.java:72:
// Does not work - ID is based on the user
This should be JavaDoc (and a little bit more descriptive)

http://gwt-code-reviews.appspot.com/721803/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to