On 2010/08/02 17:55:43, unnurg wrote:
http://gwt-code-reviews.appspot.com/721803/diff/1/7 File
bikeshed/src/com/google/gwt/sample/expenses/server/domain/GaeUserInformation.java
(right):
http://gwt-code-reviews.appspot.com/721803/diff/1/7#newcode72
bikeshed/src/com/google/gwt/sample/expenses/server/domain/GaeUserInformation.java:72:
// Does not work - ID is based on the user On 2010/08/02 17:32:43, Ray Ryan wrote: > This should be JavaDoc (and a little bit more descriptive)
Done.
Spoke to Ray offline and the objection he had was to having the getUserInformationRequest() function in the RequestFactory interface, rather than having it explicitly added in the FooRequestFactory interface. This was easy to change, so just went ahead and did it in this change - patch being uploaded now... http://gwt-code-reviews.appspot.com/721803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
